Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

@JiaLiPassion
Copy link
Collaborator

@JiaLiPassion JiaLiPassion commented Sep 9, 2018

Patch the CustomElement V1 APIs.

connectedCallback
disconnectedCallback
adoptedCallback
attributeChangedCallback

Make them run in the zone when they were defined by customElements.define.

So the issue like angular/angular#24185 may be resolved by this one.

@robwormald, @mhevery, please review, thank you!

@remackgeek
Copy link

This is cool! Does it play nice with the document-register-element polyfill (specifically 1.8.1)?

@JiaLiPassion JiaLiPassion force-pushed the custom-element branch 2 times, most recently from 87f7894 to 321137d Compare September 10, 2018 00:36
@JiaLiPassion
Copy link
Collaborator Author

@remackgeek, I believe before this PR, zone.js already support legacy document.registerElement. So document-register-element polyfill will also be supported.

@krishna217
Copy link

krishna217 commented Oct 16, 2018

Which version will this fix be available ?

@antch
Copy link

antch commented Jan 18, 2019

Just FYI for anyone following the thread, this fix is available as of 0.8.27.

@khelsisura
Copy link

@antch where?

@antch
Copy link

antch commented Jan 28, 2019

@harveyelsisura I'm not really sure what you're asking, I'm just saying that this pull request made it into the 0.8.27 release.

https://github.com/angular/zone.js/blob/v0.8.27/dist/zone.js#L3151

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants