This repository was archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 408
feat(custom-element): patch customElement v1 APIs #1133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
82dc02b to
3f9d6bf
Compare
|
This is cool! Does it play nice with the document-register-element polyfill (specifically 1.8.1)? |
87f7894 to
321137d
Compare
Collaborator
Author
|
@remackgeek, I believe before this PR, |
321137d to
2c98e2c
Compare
mhevery
approved these changes
Sep 11, 2018
|
Which version will this fix be available ? |
|
Just FYI for anyone following the thread, this fix is available as of 0.8.27. |
|
@antch where? |
|
@harveyelsisura I'm not really sure what you're asking, I'm just saying that this pull request made it into the 0.8.27 release. https://github.com/angular/zone.js/blob/v0.8.27/dist/zone.js#L3151 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch the
CustomElement V1APIs.Make them run in the
zonewhen they weredefined by customElements.define.So the issue like angular/angular#24185 may be resolved by this one.
@robwormald, @mhevery, please review, thank you!