Skip to content

Updates maxChromedriver to 77 #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2019
Merged

Conversation

nescalante
Copy link
Contributor

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nescalante
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@chosak
Copy link

chosak commented Sep 12, 2019

Bump -- is there anything else that needs to be done to get this merged in? This limitation is currently breaking Protractor tests.

@cnishina
Copy link
Contributor

Thank you! I'll get this released tomorrow morning.

@cnishina cnishina merged commit ca93fb1 into angular:legacy Sep 14, 2019
cnishina added a commit that referenced this pull request Sep 14, 2019
This reverts commit ca93fb1.
cnishina pushed a commit that referenced this pull request Sep 14, 2019
@anselmbradford
Copy link

@cnishina Is there another issue to track the status of this release?

@TravkinAlex
Copy link

@anselmbradford this has been released in webdriver-manager@12.1.7

@anselmbradford
Copy link

@TravkinAlex Ahh I see it has in npm. I was confused by it not being released in https://github.com/angular/webdriver-manager/releases

@cnishina
Copy link
Contributor

Whoops. Added a tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants