Cannot resolve definitions from pnpm modules

[lucas-labs]

Describe the bug

We are getting an error when using some pipes since we updated Angular Language Service to 0.900.14.

For example, in one of our components we have the following variable:

export class LuBadgeComponent implements OnInit {
    @Input() label: string;
    ...
}

Then, in the template we use the uppercase pipe on it:

<p>
    {{ label | uppercase }}
</p>

And we're getting the following error in VS Code:

To Reproduce

Steps to reproduce the behavior:

1. Create a component with a string variable
2. Use the uppercase pipe on the variable inside the template
3. See error

(see the example above)

Expected behavior

We expect no error from this piece of code since the code compiles correctly:

Logs

Please attach two logs:

1. Console output

[Info  - 18:18:10] Angular language server process ID: 8428
[Info  - 18:18:10] Using typescript v3.7.4 from c:\Users\lucas\.vscode\extensions\angular.ng-template-0.900.14\node_modules\typescript\lib\tsserverlibrary.js
[Info  - 18:18:10] Using @angular/language-service v9.0.2 from c:\Users\lucas\.vscode\extensions\angular.ng-template-0.900.14\server\node_modules\@angular\language-service\bundles\language-service.umd.js
[Info  - 18:18:10] Log file: c:\Users\lucas\AppData\Roaming\Code\logs\20200221T181704\exthost1\Angular.ng-template\nglangsvc.log

2. Log file
   nglangsvc.log

Screenshots

Additional context

Add any other context about the problem here.

[ayazhafiz]

Do you have @angular/common in your node_modules? Also, are you building with Angular 9?

[lucas-labs]

Hi @ayazhafiz, thanks for the answer. I do have @angular/common in my node_modules.

But, I'm using pnpm and not npm. May that be the problem? The app compiles ok and I'm sure it was working fine and without showing this error in vscode like 2 months ago.

[lucas-labs]

@ayazhafiz Regarding your question about my Angular version, I'm working with v8.2.8 in this project:

[ayazhafiz]

I think pnpm is the issue. I just made a project with pnpm and repro'd your issue

[ayazhafiz]

Not sure what we need to do to support pnpm. Looks like there is some existing issues with this on the TS side (microsoft/TypeScript#35206, microsoft/TypeScript#29221). Community contributions and suggestions are welcome.

[clov3r]

Doesn't appear to be just pnpm. I just started getting these same errors tonight, using regular npm.

[ayazhafiz]

@clov3r can you provide us with more details (per https://github.com/angular/vscode-ng-language-service/blob/master/.github/ISSUE_TEMPLATE/bug_report.md)? There are a number of reasons this error might appear.

[ivanwonder]

{
  "compilerOptions": {
    "preserveSymlinks": true
  }
}

I have submitted a PR.
@lucas-labs @clov3r I think this config can resolve the problem too.

[ayazhafiz]

Fixed by @ivanwonder's PR :)