This repository was archived by the owner on Nov 22, 2024. It is now read-only.
feat(aspnet): update engine for angular 5.0 & domino adapter #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkPieszak
changed the title
This was referenced Oct 10, 2017
Closed
Toxicable
reviewed
Oct 10, 2017
|
|
||
| import 'rxjs/add/operator/filter'; | ||
| import 'rxjs/add/operator/first'; | ||
|
|
||
| export function ngAspnetCoreEngine( | ||
| options: IEngineOptions | ||
| ): Promise<{ html: string, globals: { styles: string, title: string, meta: string, transferData?: {}, [key: string]: any } }> { |
There was a problem hiding this comment.
transferData looks like it's unused, is this from before we had TransferState?
|
Looks good, needs a commit squash though |
vikerman
approved these changes
Oct 11, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature Update to 5.x & domino
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, I kept the engine in-tact so that current users only need to update all their dependencies, and everything will work as it did before.