parseInt has a different type in Closure

[evmar]

Closure defines parseInt as having a required second argument. I think this is to handle the common mistake of doing parseInt(user_input), which does a surprising thing (octal) when user input starts with a leading 0.

For sickle's purposes, we'll need to figure out something. Ideas:

• adjust the TypeScript typings for parseInt
• coerce parseInt to undo the Closure check (which is a little disappointing)

[mprobst]

I'm mildly in favour of adjusting TypeScript typings. It's not strictly
correct, but it's much better for users. We have another change we need to
do to lib.d.ts anyway ("msOpen" on some odd file API).

Martin

Evan Martin notifications@github.com schrieb am Mi., 3. Feb. 2016 um
11:52 Uhr:

Closure defines parseInt as having a required second argument. I think
this is to handle the common mistake of doing parseInt(user_input), which
does a surprising thing (octal) when user input starts with a leading 0.

For sickle's purposes, we'll need to figure out something. Ideas:

• adjust the TypeScript typings for parseInt
• coerce parseInt to undo the Closure check (which is a little
  disappointing)

—
Reply to this email directly or view it on GitHub
#42.

[evmar]

Where would we make this modification? Can we overwrite the existing typing somehow? Or maybe we provide our own additional lib.d.ts or something?

[mprobst]

We'd have to patch our own lib.d.ts in google3, I think.

Evan Martin notifications@github.com schrieb am Do., 4. Feb. 2016 um
14:36 Uhr:

Where would we make this modification? Can we overwrite the existing
typing somehow? Or maybe we provide our own additional lib.d.ts or
something?

—
Reply to this email directly or view it on GitHub
#42 (comment).