Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

chore: add base href #368

Merged
merged 1 commit into from
Feb 27, 2017
Merged

chore: add base href #368

merged 1 commit into from
Feb 27, 2017

Conversation

Foxandxss
Copy link
Member

No description provided.

@filipesilva
Copy link
Contributor

LGTM

@Foxandxss Foxandxss merged commit 90d242f into master Feb 27, 2017
@Foxandxss Foxandxss deleted the base-href branch February 27, 2017 09:54
@atiris
Copy link
Contributor

atiris commented Feb 28, 2017

Hi,
why you modified index.html to contain 'base href="/"' element twice?
Does it have any special meaning for angular?

@Foxandxss
Copy link
Member Author

Uhh, honest mistake. Feel free to open a PR. I had this PR hanging and I thought we never did it.

@atiris
Copy link
Contributor

atiris commented Feb 28, 2017

Done, here: #395

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants