Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Docker support #36

Closed
wants to merge 2 commits into from
Closed

Docker support #36

wants to merge 2 commits into from

Conversation

cgmartin
Copy link
Contributor

Adds a Dockerfile and npm scripts to build/run the quickstart with Docker.

Usage:

  • To build and run the quickstart in a Docker container: npm run docker

Sharing this primarily as an example, since Docker image building with npm postinstall scripts is not always straightforward.

Docker has also been helpful in troubleshooting Linux-OS related issues in lite-server.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@cgmartin
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@johnpapa
Copy link

Thanks for this @cgmartin !

@wardbell
Copy link
Contributor

LGTM. Awaiting confirmation of CLA

@cgmartin
Copy link
Contributor Author

googlebot

CLAs look good, thanks!

Was there anything else you needed from me for the CLA? (this is my first experience with Google's CLA)

@wardbell
Copy link
Contributor

No, @cgmartin. It's just me. I see that you were approved since i last looked. I'll accept this shortly. Thanks!

@wardbell wardbell closed this in b63489a Apr 2, 2016
@wardbell
Copy link
Contributor

wardbell commented Apr 2, 2016

Merged at last. Thanks Chris.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants