Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

ON HOLD. need to not have a PR that is 95 files... #5038

Closed
wants to merge 4 commits into from
Closed

ON HOLD. need to not have a PR that is 95 files... #5038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37b564a
chore(test): move error tests off of the control flow.
cnishina Nov 13, 2018
6684f0f
epic refactor! things are broken! such everywhere! much epic!
cnishina Nov 20, 2018
ce4867e
well there are things that need to be cleaned up but it kinda works?
cnishina Nov 21, 2018
84fe80f
cleaned up
cnishina Nov 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .jshintignore
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions .jshintrc
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion circle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
name: Selenium Start
background: true
command: |
./node_modules/webdriver-manager/bin/webdriver-manager update
./bin/webdriver-manager update
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to just call the correct webdriver-manager in circle. We need these binaries for some tests.

./node_modules/.bin/webdriver-manager-replacement update --gecko false
./node_modules/.bin/webdriver-manager-replacement start --gecko false

Expand Down
15 changes: 4 additions & 11 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ gulp.task('tslint', function() {
});

gulp.task('lint', function(done) {
runSequence('tslint', 'jshint', 'format:enforce', done);
runSequence('tslint', 'format:enforce', done);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of these here are to clean up jshint and remove a not used done statement.

});

// prevent contributors from using the wrong version of node
Expand All @@ -59,22 +59,15 @@ gulp.task('checkVersion', function(done) {
}
});

gulp.task('built:copy', function(done) {
gulp.task('built:copy', function() {
return gulp.src(['lib/**/*.js'])
.pipe(gulp.dest('built/'));
done();
});

gulp.task('webdriver:update', function(done) {
runSpawn(done, 'node', ['bin/webdriver-manager', 'update']);
});

gulp.task('jshint', function(done) {
runSpawn(done, 'node', ['node_modules/jshint/bin/jshint', '-c',
'.jshintrc', 'lib', 'spec', 'scripts',
'--exclude=lib/selenium-webdriver/**/*.js,lib/webdriver-js-extender/**/*.js,' +
'spec/dependencyTest/*.js,spec/install/**/*.js']);
});

gulp.task('format:enforce', function() {
var format = require('gulp-clang-format');
Expand Down Expand Up @@ -107,12 +100,12 @@ gulp.task('compile_to_es5', function(done) {
});

gulp.task('prepublish', function(done) {
runSequence('checkVersion', 'jshint', 'tsc', 'built:copy', done);
runSequence('checkVersion', 'tsc', 'built:copy', done);
});

gulp.task('pretest', function(done) {
runSequence('checkVersion',
['webdriver:update', 'jshint', 'tslint', 'format'], 'tsc', 'built:copy', 'tsc:spec', done);
['webdriver:update', 'tslint', 'format'], 'tsc', 'built:copy', 'tsc:spec', done);
});

gulp.task('default',['prepublish']);
Loading