This repository was archived by the owner on Jul 29, 2024. It is now read-only.
feat(config): Support setting SELENIUM_PROMISE_MANAGER flag via the…#4023
Merged
sjelin merged 1 commit intoangular:noCFfrom Jan 27, 2017
Merged
feat(config): Support setting SELENIUM_PROMISE_MANAGER flag via the…#4023sjelin merged 1 commit intoangular:noCFfrom
SELENIUM_PROMISE_MANAGER flag via the…#4023sjelin merged 1 commit intoangular:noCFfrom
Conversation
Contributor
Author
|
CircleCI: ✅ |
Contributor
Author
|
Travis: ✅ |
juliemr
reviewed
Jan 27, 2017
lib/config.ts
Outdated
| * | ||
| * At the moment, by default, the WebDriver control flow is still enabled. You can disable it by | ||
| * setting the environment variable `SELENIUM_PROMISE_MANAGER` to `0`. In about one year, the | ||
| * control flow will be disabled by default, and you will be able to re-enable it by setting |
Member
There was a problem hiding this comment.
Instead of 'in about one year', maybe "in a webdriver release in Q4 2018"
lib/config.ts
Outdated
| * At the moment, by default, the WebDriver control flow is still enabled. You can disable it by | ||
| * setting the environment variable `SELENIUM_PROMISE_MANAGER` to `0`. In about one year, the | ||
| * control flow will be disabled by default, and you will be able to re-enable it by setting | ||
| * `SELENIUM_PROMISE_MANAGER` to `1`. In about two years, the control flow will be removed for |
Member
There was a problem hiding this comment.
Instead of "in about two year", "at a later point"
lib/config.ts
Outdated
| * | ||
| * If you don't like managing environment variables, you can set this option in your config file, | ||
| * and Protractor will handle enabling/disabling the control flow for you. Setting this option | ||
| * will override the `SELENIUM_PROMISE_MANAGER` environment variable. |
Member
There was a problem hiding this comment.
Instead say "Setting this option is higher priority than the SELENIUM_PROMISE_MANAGER environment variable".
spec/ts/noCFSmokeConf.ts
Outdated
| const env = require('../environment.js'); | ||
|
|
||
|
|
||
| // The main suite of Protractor tests. |
spec/ts/noCF/smoke_spec.ts
Outdated
|
|
||
| it('should allow handling errors', async function() { | ||
| await browser.get('index.html#/form'); | ||
| await $('.nopenopenope').getText().then(async function(/* string */) { |
Member
There was a problem hiding this comment.
Would it make sense for this test to instead use try/catch (that works with async, yeah?)
Member
|
Whoo! A few comments, mostly on wording. |
Contributor
Author
|
@juliemr all comments addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… config
Closes #3691