This repository was archived by the owner on Jul 29, 2024. It is now read-only.
docs(webdriver): protractor style docs for getDriver, getId, and click
#3101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @example | ||
| * // returns the dog web element | ||
| * var dog = element(by.css('.dog')).getWebElement(); | ||
| * expect(dog.getId()).not.toBe(undefined); |
There was a problem hiding this comment.
not toBe undefined? What is it then? An empty string?
There was a problem hiding this comment.
getId returns a string that is a number. So, I'm getting the id to the web element and it exists.
There was a problem hiding this comment.
Ok, I understand now. You should add a line up top explaining what this method actually does, because I assumed it got the id attribute of an element
cnishina
force-pushed
the
pr_fixdocs_webdriver
branch
2 times, most recently
from
b81167a to
a1fa6a2
Compare
cnishina
force-pushed
the
pr_fixdocs_webdriver
branch
from
a1fa6a2 to
184be54
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.