Skip to content
This repository was archived by the owner on Jul 29, 2024. It is now read-only.
This repository was archived by the owner on Jul 29, 2024. It is now read-only.

Protractor unit test not actually testing anything, then breaks in Jasmine 2.9+ #4708

Open
@slackersoft

Description

@slackersoft

The "local connect with the selenium standalone jar" spec isn't actually testing anything because it is calling Jasmine's beforeEach, afterEach, and it inside of another it. This probably caused the build breakages when Jasmine 2.9 was released, because that release made this throw an error and fail the test suite. The test is here, but when I remove the outer it so that the inner one actually execute, the spec fails because the Error that is thrown doesn't have any code at all on it, instead it is:

Error: Do not know how to build driver: foobar explorer; did you forget to call usingServer(url)?
        at Builder.build (/Users/pivotal/workspace/protractor/node_modules/selenium-webdriver/index.js:663:15)
        at Local.getNewDriver (/Users/pivotal/workspace/protractor/built/driverProviders/driverProvider.js:53:33)
        at /Users/pivotal/workspace/protractor/spec/unit/driverProviders/local_test.js:64:19

And I'm not sure the right Protractor way to solve this. I was looking to send in a PR to update for Jasmine 3.0, which was released recently, but, I am unable to get a green test suite locally due to this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions