Rename noReplay to replay #69
Description
Note: for support questions, please use the Universal Slack Channcel or https://gitter.im/angular/universal
- I'm submitting a ...
- bug report
- feature request
- Which parts of preboot are affected by this issue?
- server side
- client side
- inline
- build process
- docs
- tests
- Do you want to request a feature or report a bug?
A feature (renaming an existing feature).
- What is the current behavior?
PrebootModule.withConfig accepts noReplay as a parameter, false by default.
- If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem by creating a github repo.
N/A
- What is the expected behavior?
The property should be named replay and be true by default, just like buffer.
- What is the motivation / use case for changing the behavior?
It's well established that negatives are more difficult to read, especially when assigned a negative value, creating a double negative. Current API is also inconsistent with the buffer option that is set to true by default.
- Please tell us about your environment:
N/A
- Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
Preboot 6 requires a different way of importing inside of an Angular NgModule so people upgrading will have to change their imports anyway. That's a good opportunity to rename the confusingly named option.
cc @CaerusKaru as we talked about it outside of GitHub.