This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): only restore focus with keyboard interaction #9923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
fix/focus-dialog-restore
branch
from
df99f6e to
3cb318f
Compare
ThomasBurleson
added
needs: presubmit
and removed
needs: review
* Currently the dialog always restores focus to the origin element upon close. * The focus should be only restored if the dialog was opened with keyboard interaction - Same behavior as with the sidenav closing. Fixes angular#7963.
devversion
force-pushed
the
fix/focus-dialog-restore
branch
from
3cb318f to
b8889b6
Compare
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7963.