This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(theming): match preceding selectors as well #9484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
in progress
devversion
force-pushed
the
fix/theming-rule-match
branch
from
991648f to
db0c563
Compare
devversion
removed
the
in progress
* The theming service currently only matches from the beginning of the `md-default-theme`, but all preceding selectors are being ignored. Fixes angular#9480
devversion
force-pushed
the
fix/theming-rule-match
branch
from
db0c563 to
a3c808e
Compare
|
I've been testing it out together with Paul and it LGTM. |
|
Ping @EladBezalel for review. This was our discussion in the meeting and was planned to go into |
|
As long it was tested by @crisbeto and @devversion locally - LGTM |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Sep 11, 2016
* The theming service currently only matches from the beginning of the `md-default-theme`, but all preceding selectors are being ignored. Fixes angular#9480
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-default-theme, but all preceding selectors without whitespaces are being ignored..md-default-themeclass).borderCSS property.Shout-out again to @crisbeto
Fixes #9480