Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

chore(sass): fix module builds #12138

Merged
merged 1 commit into from
Dec 16, 2021
Merged

chore(sass): fix module builds #12138

merged 1 commit into from
Dec 16, 2021

Conversation

Splaktar
Copy link
Contributor

AngularJS Material is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See Long Term Support for more detail.

PR Checklist

Please check your PR fulfills the following requirements:

  • Does this PR fix a regression since 1.2.0, a security flaw, or a problem caused by a new browser version?
  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[x] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

What is the new behavior?

  • fixes module builds broken by PR build: fix SCSS division deprecation #12112
  • break module imports out into a separate file since it behaves differently than
    Sass variables.
  • add a new hoistScssAtUseStatements() function to deduplicates @use statements
    and move them to the top as required by Sass.
  • start testing the module and closure builds for every PR and don't let breaking
    changes get to master before we find them.
  • update CircleCI NodeJS image and comments about where to find new images
  • update caniuse-lite

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

- fixes module builds broken by PR #12112
- break module imports out into a separate file since it behaves differently than
  Sass variables.
- add a new `hoistScssAtUseStatements()` function to deduplicates @use statements
  and move them to the top as required by Sass.
- start testing the module and closure builds for every PR and don't let breaking
  changes get to `master` before we find them.
- update CircleCI NodeJS image and comments about where to find new images
- update caniuse-lite
@Splaktar Splaktar self-assigned this Dec 15, 2021
@Splaktar Splaktar added P1: urgent Urgent issues that should be addressed in the next minor or patch release. type: build type: chore labels Dec 15, 2021
@Splaktar Splaktar added this to the 1.2.4 milestone Dec 15, 2021
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Dec 15, 2021
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Dec 16, 2021
@Splaktar Splaktar merged commit 625adc5 into master Dec 16, 2021
@Splaktar Splaktar deleted the fix-modules-build branch December 16, 2021 07:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: build type: chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants