Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(bottom-sheet): component theme now supports dark mode #11380

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

See Before screenshots below.

Issue Number:
N/A

What is the new behavior?

See After screenshots below.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Before

screen shot 2018-07-22 at 4 11 13 am
screen shot 2018-07-22 at 4 11 24 am
screen shot 2018-07-22 at 4 11 48 am
screen shot 2018-07-22 at 4 11 55 am

After

screen shot 2018-07-22 at 4 07 50 am
screen shot 2018-07-22 at 4 08 04 am
screen shot 2018-07-22 at 4 09 29 am
screen shot 2018-07-22 at 4 09 38 am

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jul 22, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Jul 22, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review P3: important Important issues that really should be fixed when possible. labels Jul 22, 2018
@mmalerba mmalerba merged commit 4cecebb into master Jul 25, 2018
@Splaktar Splaktar deleted the fixBottomSheetDarkMode branch July 30, 2018 06:39
Splaktar added a commit that referenced this pull request Jul 31, 2018
<!-- 
Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed.
-->
## PR Checklist
Please check that your PR fulfills the following requirements:
- [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format)
- [ ] Tests for the changes have been added or this is not a bug fix / enhancement
- [x] Docs have been added, updated, or were not required

## PR Type
What kind of change does this PR introduce?
<!-- Please check the one that applies to this PR using "x". -->
```
[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:
```

## What is the current behavior?
See Before screenshots below.
<!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. -->
Issue Number: 
N/A

## What is the new behavior?
See After screenshots below.

## Does this PR introduce a breaking change?
```
[ ] Yes
[x] No
```
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
<!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. -->

## Other information

### Before
![screen shot 2018-07-22 at 4 11 13 am](https://user-images.githubusercontent.com/3506071/43043610-6d51e650-8d65-11e8-8c2a-da73944f872e.png)
![screen shot 2018-07-22 at 4 11 24 am](https://user-images.githubusercontent.com/3506071/43043611-6d5e7b9a-8d65-11e8-91c5-57c58bf606e3.png)
![screen shot 2018-07-22 at 4 11 48 am](https://user-images.githubusercontent.com/3506071/43043612-6d6d5728-8d65-11e8-96e0-010c4d1cd176.png)
![screen shot 2018-07-22 at 4 11 55 am](https://user-images.githubusercontent.com/3506071/43043613-6d7c034a-8d65-11e8-9577-95228b822c95.png)

### After
![screen shot 2018-07-22 at 4 07 50 am](https://user-images.githubusercontent.com/3506071/43043600-3475240a-8d65-11e8-968d-a1dd23475a74.png)
![screen shot 2018-07-22 at 4 08 04 am](https://user-images.githubusercontent.com/3506071/43043601-348382fc-8d65-11e8-91d4-cb9ce955bed3.png)
![screen shot 2018-07-22 at 4 09 29 am](https://user-images.githubusercontent.com/3506071/43043602-34922528-8d65-11e8-997a-343ad874073f.png)
![screen shot 2018-07-22 at 4 09 38 am](https://user-images.githubusercontent.com/3506071/43043603-349ebf40-8d65-11e8-8cb9-e797d618756b.png)
Splaktar added a commit that referenced this pull request Aug 2, 2018
<!-- 
Filling out this template is required! Do not delete it when submitting a Pull Request! Without this information, your Pull Request may be auto-closed.
-->
## PR Checklist
Please check that your PR fulfills the following requirements:
- [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format)
- [ ] Tests for the changes have been added or this is not a bug fix / enhancement
- [x] Docs have been added, updated, or were not required

## PR Type
What kind of change does this PR introduce?
<!-- Please check the one that applies to this PR using "x". -->
```
[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:
```

## What is the current behavior?
See Before screenshots below.
<!-- Please describe the current behavior that you are modifying and link to one or more relevant issues. -->
Issue Number: 
N/A

## What is the new behavior?
See After screenshots below.

## Does this PR introduce a breaking change?
```
[ ] Yes
[x] No
```
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
<!-- Note that breaking changes are highly unlikely to get merged to master unless the validation is clear and the use case is critical. -->

## Other information

### Before
![screen shot 2018-07-22 at 4 11 13 am](https://user-images.githubusercontent.com/3506071/43043610-6d51e650-8d65-11e8-8c2a-da73944f872e.png)
![screen shot 2018-07-22 at 4 11 24 am](https://user-images.githubusercontent.com/3506071/43043611-6d5e7b9a-8d65-11e8-91c5-57c58bf606e3.png)
![screen shot 2018-07-22 at 4 11 48 am](https://user-images.githubusercontent.com/3506071/43043612-6d6d5728-8d65-11e8-96e0-010c4d1cd176.png)
![screen shot 2018-07-22 at 4 11 55 am](https://user-images.githubusercontent.com/3506071/43043613-6d7c034a-8d65-11e8-9577-95228b822c95.png)

### After
![screen shot 2018-07-22 at 4 07 50 am](https://user-images.githubusercontent.com/3506071/43043600-3475240a-8d65-11e8-968d-a1dd23475a74.png)
![screen shot 2018-07-22 at 4 08 04 am](https://user-images.githubusercontent.com/3506071/43043601-348382fc-8d65-11e8-91d4-cb9ce955bed3.png)
![screen shot 2018-07-22 at 4 09 29 am](https://user-images.githubusercontent.com/3506071/43043602-34922528-8d65-11e8-997a-343ad874073f.png)
![screen shot 2018-07-22 at 4 09 38 am](https://user-images.githubusercontent.com/3506071/43043603-349ebf40-8d65-11e8-8cb9-e797d618756b.png)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review ui: theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants