-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(toolbar): input placeholders and ink need more contrast #11378
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
b5cb673
to
67a8034
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
67a8034
to
fe260da
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
PR #11953 builds upon this and improves toolbar and input theming a bit more. |
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Inputs in toolbars aren't themed properly and don't meet a11y guidelines for contrast.
Issue Number:
Fixes #7987. This depends on #11376 being merged first.
What is the new behavior?
Inputs in toolbars are themed properly and have contrast to make them readable.
Does this PR introduce a breaking change?
Other information
Before

After
