Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(toolbar): input placeholders and ink need more contrast #11378

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

Splaktar
Copy link
Contributor

@Splaktar Splaktar commented Jul 20, 2018

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Inputs in toolbars aren't themed properly and don't meet a11y guidelines for contrast.

Issue Number:
Fixes #7987. This depends on #11376 being merged first.

What is the new behavior?

Inputs in toolbars are themed properly and have contrast to make them readable.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Before
Screen Shot 2019-08-26 at 14 13 02

After
Screen Shot 2019-08-26 at 14 12 09

@Splaktar Splaktar self-assigned this Jul 20, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Jul 20, 2018
@Splaktar Splaktar added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs type: bug ui: theme P1: urgent Urgent issues that should be addressed in the next minor or patch release. a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. labels Jul 20, 2018
@Splaktar Splaktar added this to the 1.1.12 milestone Sep 24, 2018
@Splaktar Splaktar modified the milestones: 1.1.12, 1.2.0 Oct 20, 2018
@Splaktar Splaktar force-pushed the themeInputsInToolbar branch from b5cb673 to 67a8034 Compare August 26, 2019 18:07
@Splaktar Splaktar added the Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. label Aug 26, 2019
@Splaktar Splaktar changed the title WIP: fix(toolbar): input placeholders and ink need more contrast fix(toolbar): input placeholders and ink need more contrast Aug 26, 2019
@Splaktar Splaktar removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Aug 26, 2019
@Splaktar Splaktar requested a review from mmalerba June 19, 2020 00:17
@Splaktar Splaktar removed the Blocked Progress on this issue is blocked. Primarily used for PRs that are blocked by presubmit feedback. label Jun 19, 2020
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar force-pushed the themeInputsInToolbar branch from 67a8034 to fe260da Compare July 1, 2020 00:25
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Jul 1, 2020
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review pr: lgtm This PR has been approved by the reviewer labels Jul 1, 2020
@Splaktar Splaktar merged commit a82fc93 into master Jul 1, 2020
@Splaktar Splaktar deleted the themeInputsInToolbar branch July 1, 2020 00:31
@Splaktar
Copy link
Contributor Author

Splaktar commented Jul 1, 2020

PR #11953 builds upon this and improves toolbar and input theming a bit more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug ui: theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(input): placeholder text inside toolbar is difficult to read
3 participants