This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(checkbox): handle links in transcluded label in an a11y-friendly way #11154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Splaktar
added
needs: unit tests
Splaktar
added
a11y
jelbourn
reviewed
Mar 8, 2018
Splaktar
force-pushed
the
checkboxA11yLinks
branch
from
9c8764f to
79f3d96
Compare
Splaktar
changed the title
Splaktar
force-pushed
the
checkboxA11yLinks
branch
2 times, most recently
from
212d940 to
9882de3
Compare
Splaktar
removed
needs: unit tests
jelbourn
added
pr: merge ready
|
There are several broken screenshot tests involving checkboxes that contain links |
Splaktar
added
needs: team discussion
Splaktar
removed
pr: merge ready
|
I am going to push this to 1.2.0 for now and investigate the autocomplete a11y issues. They are also likely to require breaking changes to fix. The combination of these breaking changes along with possible breaking changes for chips and select a11y and other breaking changes related to Material Design Spec alignment should make a good case for putting out a 1.2.0 release.
|
Splaktar
added
- Breaking Change
in progress
Splaktar
removed
pr: presubmit-failures
needs: team discussion
Splaktar
force-pushed
the
checkboxA11yLinks
branch
from
9882de3 to
a8b31bd
Compare
- JAWS and Voiceover should properly handle links in md-checkbox labels - Wrapping the checkbox in a `md-input-container` is required - for using links in checkbox labels due to layout considerations - Add new demos for different types of a11y checkbox labels - don't toggle the checkbox on link actions - don't output aria warnings when using `aria-labelledby` - require `md-input-container` when using links in checkbox labels Fixes #11134. BREAKING CHANGE: If you've created a custom solution to style links within `md-checkbox` labels, then you may need to remove or change that code now. This is because we automatically detect `<a>` tags in these labels and re-render them in an accessible way.
Splaktar
force-pushed
the
checkboxA11yLinks
branch
from
a8b31bd to
16fdc61
Compare
Splaktar
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
JAWS and Voiceover can't get to links in
md-checkboxlabels.Issue Number:
Fixes #11134
What is the new behavior?
md-checkboxlabels.md-input-containeris required for using links in checkbox labels due to layout considerations.Does this PR introduce a breaking change?
Other information