docs(changelog): add md-selected-text not accepting HTML anymore as a breaking change in 1.1.5 #10912
Description
HI! Recently we wanted to migrate from angularjs material 1.1.1 to 1.1.4 (but finally did 1.1.5 as described below), we used the CHANGELOG.md as our migration tour guide : )
But it wasn't helpful in some situations:
-
Our website is multi-directional, the first thing we encountered was in 1.1.4, all tooltips in RTL were attached to the right-most of the page instead of element. I'm not sure which version broke it, but I think there should be a breaking change log about this in your changelog file. That's why we decided to move to 1.1.5 instead of 1.1.4 (which later we found was a good thing : ))
-
the main reason we decided to update our angularjs material was that
multipleoption of dialog which is added from 1.1.4 to documentation : https://material.angularjs.org/1.1.4/api/service/$mdDialog
But nowhere in changelog it was mentioned (btw, its great, thanks : )) -
There is a big breaking change which annoyed us a lot and took some time to debug and find where the problem is, all our
md-colorswere broke. like this:md-colors="{background:'green-500'}"resulted in an error like this :'-green' couldn't be find in color pallete(or something like that). That-(dash) was added at the beginning of every color we used and broke them all. That was caused in 1.1.2. by this I think :7090a1f
The solution was just to add amd-theme="default"to our<body>tag and to each of our dialogs one by one (even if dialogs were opened inside body), that just solved the problem, I assume it as a bug, because it took away default usage ofmd-colors, but if its not a bug, please add it to breaking changes of 1.1.2
something we found that might be helpful about this one were these few lines:`compile: function (tElem, tAttrs) { var shouldWatch = shouldColorsWatch(); return function (scope, element, attrs, ctrl) {` `var mdThemeController = ctrl[0];` `var lastColors = {};`
do you see that ctrl[0] ? it was null in 1.1.1, but it existed as an object from 1.1.2
- also a minor thing : in your 1.1.5, there is a long text explaining something about $mdCompile, that breaks the nice flow of your beautiful bullet list changelog, and also its scary, first I thought maybe everything is changed in 1.1.5 : ). I think it would be nicer if a link is provided to somewhere else which explains it.
Thanks ! :)
Keep up the good work 👍