This repository was archived by the owner on Dec 18, 2024. It is now read-only.
Sidenav fixes #389
Merged
Sidenav fixes #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mmalerba can you take a look? |
mmalerba
reviewed
Feb 12, 2018
|
|
||
| &:focus { | ||
| // override the default background | ||
| background: rgba(0, 0, 0, $nav-background-focus-opacity) !important; |
There was a problem hiding this comment.
is the !important necessary? can we just make the rule more specific?
| <table-of-contents #toc | ||
| *ngIf="showToc$ | async" |
There was a problem hiding this comment.
I don't think we use the $ naming style anywhere else
| // Listen to changes on the current route for the doc id (e.g. button/checkbox) and the | ||
| // parent route for the section (material/cdk). | ||
| combineLatest(_route.params, _route.parent.params).pipe( | ||
| this._subscription = combineLatest(_route.params, _route.parent.params).pipe( |
There was a problem hiding this comment.
we prefer takeUntil(this._destroyed) over managing the subscription
|
Poke @amcdnl on this one |
|
In this PR, I also:
|
mmalerba
approved these changes
Apr 2, 2018
| @@ -41,6 +54,10 @@ export class ComponentViewer { | |||
| } | |||
| }); | |||
| } | |||
|
|
|||
| ngOnDestroy(): void { | |||
| this._destroyed.next(); | |||
There was a problem hiding this comment.
also this._destroyed.complete()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: