-
Notifications
You must be signed in to change notification settings - Fork 395
fix(stack-blitz-tests): revert enabling Ivy as it broke harness examples #1009
fix(stack-blitz-tests): revert enabling Ivy as it broke harness examples #1009
Conversation
The It's not clear why Ivy should be disabled - is there something that the framework needs to fix in order for us to turn it back on? |
This workaround from Pete might work to keep Ivy enabled: |
@andrewseguin not by |
@andrewseguin also after fixing the Error in src/app/input-harness-example.spec.ts (14:1)
Cannot find name 'describe'. Do you need to install type definitions for a test runner?
Try `npm i --save-dev @types/jest` or `npm i --save-dev @types/mocha`. Disabling Ivy resolves this. It's unclear why there are references to Jest or Mocha when Jasmine is being used. |
I don't know why the error happens, but the error message comes from TypeScript itself: https://github.com/microsoft/TypeScript/blob/9906092db25aae8bd6f6b04aef5e8906251fcf13/src/compiler/diagnosticMessages.json#L2489 🤷 |
@crisbeto unfortunately, that's not working for me in https://stackblitz.com/edit/jasmine-ivy-workaround?file=tsconfig.app.json. |
Would everything else work if we put a |
- remove tslint and codelyzer from examples - update jasmine dependencies - remove unused material-module.ts from test assets - add jasmine-core to package.json in stack-blitz-tests/ - disable `noImplicitAny` in stack-blitz-tests' tsconfig.spec.json since `jasmine-core/lib/jasmine-core/jasmine.js` imported in `test/jasemine-setup.ts` is not compatible Fixes angular#997
b901073
to
769a36c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #1037 tracks properly re-enabling Ivy and ensuring that the Harness Examples work. |
noImplicitAny
in stack-blitz-tests' tsconfig.spec.json sincejasmine-core/lib/jasmine-core/jasmine.js
imported intest/jasemine-setup.ts
is not compatible
Fixes #997
The
stack-blitz-tests/
asset files are used for generating the StackBlitz examples for the test harnesses. In a past PR, we set them along with all of our StackBlitz assets to use Ivy. This worked fine for our component examples, but broke our Harness examples as mentioned in #997 (comment). This PR reverts that change by switching the Harness examples to use View Engine in StackBlitz. The component examples will continue to use Ivy in StackBlitz.Additionally, this PR fixes some issues blocking the use of Ivy with the Harness examples (since
jasmine-core/lib/jasmine-core/jasmine.js
doesn't build in strict mode withnoImplicitAny
enabled). It also updates and removes some other dependencies.