This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix: cache fetched docs #1001
Merged
fix: cache fetched docs #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we fetch a doc every time we need to display it which means that user navigating between two pages will have to request the same information multiple times. These changes add a caching layer since the information isn't going to change.
devversion
approved these changes
May 28, 2021
| } | ||
|
|
||
| const stream = this._http.get(url, {responseType: 'text'}).pipe(shareReplay(1)); | ||
| return stream.pipe(tap(() => this._cache[url] = stream)); |
There was a problem hiding this comment.
My expertise with RxJS is limited, but is there are a reason to cache the stream in the tap? Is this to avoid caching cases where an initial XHR request failed?
There was a problem hiding this comment.
Yeah, I was trying to avoid caching a failed request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we fetch a doc every time we need to display it which means that user navigating between two pages will have to request the same information multiple times.
These changes add a caching layer since the information isn't going to change.