Skip to content

Defer GitHub releases until after NPM packages are published #747

Open

Description

Action item from requiem/doc/postmortem475066.

In the 14.1.0-rc.0 release, the NPM publish operation failed several times. However the GitHub release was published before NPM failed, so each attempt published a GitHub release which isn't actually usable and confuses people watching the repository. These phantom releases also need to be manually cleaned up afterwards.

We should consider deferring the GitHub release until after the NPM publish is successful. If the NPM publish does fail, we might want to print an error message that the GitHub release was not posted, but that's probably less of a concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions