fix(global-position-strategy): ignoring width and height from OverlayConfig #9774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Feb 5, 2018
| @@ -86,14 +96,14 @@ export class GlobalPositionStrategy implements PositionStrategy { | |||
| /** | |||
| * Sets the overlay width and clears any previously set width. | |||
| * @param value New width for the overlay | |||
| * @deprecated Pass the `width` through the `OverlayConfig`. | |||
| * @deletion-target 6.0.0 | |||
There was a problem hiding this comment.
This will have to be 7.0; any deprecated API has to stick around for at least one full major release cycle before being removed.
…Config * Switches to using the `width` and `height` from the `OverlayConfig`, rather than the properties on the `GlobalPositionStrategy`. * Deprecates the `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height` methods in favor of passing the dimensions through the config. * Reworks the `GlobalPositionStrategy` testing setup to make it less prone to breaking if any of the `OverlayRef` internals change. Fixes angular#9715.
crisbeto
force-pushed
the
9715/global-overlay-width-height
branch
from
2d4c1d9 to
acd393a
Compare
jelbourn
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Feb 8, 2018
…Config (#9774) * Switches to using the `width` and `height` from the `OverlayConfig`, rather than the properties on the `GlobalPositionStrategy`. * Deprecates the `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height` methods in favor of passing the dimensions through the config. * Reworks the `GlobalPositionStrategy` testing setup to make it less prone to breaking if any of the `OverlayRef` internals change. Fixes #9715.
tinayuangao
pushed a commit
that referenced
this pull request
Feb 9, 2018
…Config (#9774) * Switches to using the `width` and `height` from the `OverlayConfig`, rather than the properties on the `GlobalPositionStrategy`. * Deprecates the `GlobalPositionStrategy.width` and `GlobalPositionStrategy.height` methods in favor of passing the dimensions through the config. * Reworks the `GlobalPositionStrategy` testing setup to make it less prone to breaking if any of the `OverlayRef` internals change. Fixes #9715.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
widthandheightfrom theOverlayConfig, rather than the properties on theGlobalPositionStrategy.GlobalPositionStrategy.widthandGlobalPositionStrategy.heightmethods in favor of passing the dimensions through the config.GlobalPositionStrategytesting setup to make it less prone to breaking if any of theOverlayRefinternals change.Fixes #9715.