feat(ripple): support ripple fade-out on pointer up #9694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, ripples in Angular Material will only fade out if the pointer is released and the enter animation completed. This behavior is similar in the MDC implementation of the Material Design guidelines. In some scenarios, developers prefer fading out the ripples immediately on pointer release. Similarly the Material Design guidelines also have some videos that show ripples that seem to follow that behavior as well. To be able to provide the necessary flexibility (as we already did with the animation durations), the `terminateOnPointerUp` global option has been added. Closes angular#9577
googlebot
added
the
cla: yes
praveeno
approved these changes
Jan 30, 2018
jelbourn
approved these changes
Jan 30, 2018
src/lib/core/ripple/ripple.spec.ts
Outdated
|
|
||
| // Since the enter duration is bigger than the exit duration, the enter duration timer | ||
| // will still exist. To properly finish all timers, we just wait the remaining time. | ||
| tick (enterDuration - exitDuration); |
There was a problem hiding this comment.
Done. Added this PR to release: minor.
devversion
added
action: merge
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Feb 1, 2018
* feat(ripple): support ripple fade-out on pointer up By default, ripples in Angular Material will only fade out if the pointer is released and the enter animation completed. This behavior is similar in the MDC implementation of the Material Design guidelines. In some scenarios, developers prefer fading out the ripples immediately on pointer release. Similarly the Material Design guidelines also have some videos that show ripples that seem to follow that behavior as well. To be able to provide the necessary flexibility (as we already did with the animation durations), the `terminateOnPointerUp` global option has been added. Closes angular#9577 * Comment improvements * Remove unnecessary whitespace
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, ripples in Angular Material will only fade out if the pointer is released and the enter animation completed. This behavior is similar in the MDC implementation of the Material Design guidelines.
In some scenarios, developers prefer fading out the ripples immediately on pointer release. Similarly the Material Design guidelines also have some videos that show ripples that seem to follow that behavior as well. To be able to provide the necessary flexibility (as we already did with the animation durations), the
terminateOnPointerUpglobal option has been added.@jelbourn @willshowell I wasn't that sure about the naming of the option, because technically just having
terminateonMouseUpis incorrect, because touch events are also supported.Closes #9577