demo(sidenav): add accessibility demo pages #7498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
fixes #6501 |
tinayuangao
reviewed
Oct 9, 2017
| </button> | ||
| <h1 class="a11y-demo-sidenav-app-name">Dual Sidenav App</h1> | ||
| <span class="a11y-demo-sidenav-spacer" aria-hidden="true"></span> | ||
| <button mat-icon-button aria-label="Playlist menu" (click)="endSnav.toggle()"> |
There was a problem hiding this comment.
Is there a way to focus on the playlist items when toggle sidenav? The focus stays in the toggle icon button, and user need to go through the left sidenav to reach the second sidenav.
|
done |
mmalerba
added
pr: lgtm
action: merge
| preserveWhitespaces: false, | ||
| }) | ||
| export class SidenavMobileAccessibilityDemo implements OnDestroy { | ||
| mobileQuery = matchMedia('(max-width: 600px)'); |
There was a problem hiding this comment.
Looks like this is breaking internal build, where is this imported?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.