Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo(slider): add slider a11y demos #6230

Merged
merged 3 commits into from
Aug 4, 2017
Merged

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Aug 2, 2017

No description provided.

@mmalerba mmalerba added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Aug 2, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 2, 2017
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,36 @@
<section>
<h2>Continuous slider (e.g. color component sliders)</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a <p> with something like Select the red, blue, and green values for your color. ?
(similar for other demos)

@mmalerba
Copy link
Contributor Author

mmalerba commented Aug 3, 2017

comments addressed

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 3, 2017
@tinayuangao tinayuangao merged commit 787a8f0 into angular:master Aug 4, 2017
crisbeto pushed a commit to crisbeto/material2 that referenced this pull request Aug 5, 2017
* demo(slider): add slider a11y demos

* add description text to each example
@mmalerba mmalerba deleted the slider-a11y branch April 3, 2018 15:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants