chore(cdk): create cdk/collections #6208
Conversation
andrewseguin
requested review from
amcdnl,
crisbeto,
kara and
tinayuangao
as code owners
googlebot
added
the
cla: yes
andrewseguin
force-pushed
the
cdk-collections
branch
from
6e773b7 to
62c3ec1
Compare
.github/CODEOWNERS
Outdated
| @@ -49,7 +49,8 @@ src/lib/core/datetime/** @mmalerba | |||
| # CDK | |||
| src/cdk/coercion/** @jelbourn | |||
| src/cdk/rxjs/** @jelbourn | |||
| src/cdk/observe-content/** @crisbeto @jelbourn | |||
| src/cdk/observe-content/** @jelbourn @crisbeto | |||
| src/cdk/collections/** @jelbourn @andrewseguin | |||
There was a problem hiding this comment.
Can you add me to this one as well since I did the SelectionModel initially? Also if we're making the SelectionModel a part of the CDK, should we remove the @docs-private?
There was a problem hiding this comment.
For sure, added you as an owner. I removed @docs-private as well since we are advising users to apply it for their tables.
| @@ -52,6 +52,7 @@ System.config({ | |||
| '@angular/cdk/a11y': 'dist/packages/cdk/a11y/index.js', | |||
| '@angular/cdk/bidi': 'dist/packages/cdk/bidi/index.js', | |||
| '@angular/cdk/coercion': 'dist/packages/cdk/coercion/index.js', | |||
| '@angular/cdk/collections': 'dist/packages/cdk/collections/index.js', | |||
There was a problem hiding this comment.
You can tell, adding this to every system configuration is annoying :)
I'm thinking about a more dynamic approach here
mmalerba
added
pr: needs rebase
and removed
action: merge
|
please rebase |
andrewseguin
force-pushed
the
cdk-collections
branch
from
fa93d74 to
71d2d9c
Compare
|
Rebased |
andrewseguin
added
action: merge
andrewseguin
force-pushed
the
cdk-collections
branch
from
cd538e8 to
39e209b
Compare
andrewseguin
force-pushed
the
cdk-collections
branch
from
39e209b to
1b9ba9b
Compare
kara
added
pr: needs rebase
and removed
pr: needs rebase
action: merge
|
@andrew Can you rebase? |
andrewseguin
force-pushed
the
cdk-collections
branch
from
1b9ba9b to
129f175
Compare
andrewseguin
added
action: merge
|
Rebased |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Contains data-source, collection-viewer, and selection.
Opening up the PR for discussion on what should be in the directory (or if it should exist). Data source and collections viewer doesn't need to be tied to the table since other components (tree) can use em.