a11y(chips): Add accessibility demo page for chips #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@tinayuangao does this need to be rebased on another PR? |
tinayuangao
force-pushed
the
a11y-chips
branch
2 times, most recently
from
3e349ef to
b32c7e3
Compare
jelbourn
reviewed
Jul 27, 2017
| <md-chip>Chip 1</md-chip> | ||
| <md-chip>Chip 2</md-chip> | ||
| <md-chip>Chip 3</md-chip> | ||
| </md-chip-list> |
There was a problem hiding this comment.
Same comment on more "real world" content here
| <md-chip color="accent" selected="true">Accent</md-chip> | ||
| <md-chip color="warn" selected="true">Warn</md-chip> | ||
| </md-chip-list> | ||
| </section> |
There was a problem hiding this comment.
Maybe add a comment here that this example is good to have for contrast-radio checking
|
Changed to real world examples. Please take another look. Thanks! |
jelbourn
approved these changes
Jul 29, 2017
| {{person.name}} | ||
| </md-chip> | ||
| </md-chip-list> | ||
| <input mdInput placeholder="New Contributor..." |
There was a problem hiding this comment.
Should add an aria-label for the input
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.