chore(): use core-js instead of es6-shim #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace es6-shim, es6-promise and reflect-metadata with core-js, because it coveres all required dependencies / shims in one single dependency / library. Closes angular#477.
googlebot
added
the
cla: yes
|
LGTM |
andrewseguin
pushed a commit
to andrewseguin/components
that referenced
this pull request
Oct 15, 2018
* Currently the `fetch-assets` script always fetches the data from the `master` branch. This is problematic because if we release a new patch release, we will incorrectly have the docs content for the upcoming major version. * Adds a small note that makes the publisher aware of the docs-content that should be kept updated.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace es6-shim, es6-promise and reflect-metadata with core-js, because it coveres all required dependencies / shims in one single dependency / library.
@jelbourn - Not sure, with replacing the reflect-metadata dependency with core-js (zloirock/core-js#152).
Closes #477.