refactor: remove custom error classes #4324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
mmalerba
added
presubmit failures
|
Can we deprecate instead of removing |
|
@mmalerba we should eliminate those, they shouldn't be doing that |
|
Restored and marked |
|
Beat me by a few seconds there @jelbourn. |
|
It's okay with me to leave it, then, so long as we also remove them from Google |
|
@crisbeto can you rebase? |
|
Also you can totally delete |
* Removes the custom `MdError` class and refactors all of the classes that extended it into functions. * Removes a few of the single-function `*-errors.ts` files and inlines their content. Fixes angular#4317.
crisbeto
force-pushed
the
4317/remove-custom-errors
branch
from
4b7c996 to
966916b
Compare
|
Done @jelbourn. A few new |
jelbourn
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MdErrorclass and refactors all of the classes that extended it into functions.*-errors.tsfiles and inlines their content.Fixes #4317.