Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkbox, radio): ripple error on focus event #3869

Merged
merged 1 commit into from
Apr 11, 2017
Merged

fix(checkbox, radio): ripple error on focus event #3869

merged 1 commit into from
Apr 11, 2017

Commits on Apr 1, 2017

  1. fix(checkbox, radio): ripple error on focus event 

    * The checkbox and radio disable the ripples using a `*ngFor` check. This causes the `ViewChildren` instance to turn null. The reference is required for the focus indicators.

* If ripples are disabled there will be still ripples on click. This is due to the fact that label elements redirect focus to the underlying input element. The `focusOrigin` is therefore `program` and a focus ripple will show up.

* Tests had to be adjusted because the `[md-ripple]` element won't be removed anymore. Therefore the tests now confirm that no ripples are showing up.

Fixes angular#3856.
    @devversion
    devversion committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    0c567c4 View commit details
    Browse the repository at this point in the history