Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make app tasks optional #3361

Merged
merged 1 commit into from
Mar 1, 2017
Merged

build: make app tasks optional #3361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/gulp/task_helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ export function cleanTask(glob: string) {
/** Build an task that depends on all application build tasks. */
export function buildAppTask(appName: string) {
const buildTasks = ['vendor', 'ts', 'scss', 'assets']
.map(taskName => `:build:${appName}:${taskName}`);
.map(taskName => `:build:${appName}:${taskName}`)
.filter(taskName => gulp.hasTask(taskName));

return (done: () => void) => {
gulpRunSequence(
Expand Down
3 changes: 0 additions & 3 deletions tools/gulp/tasks/e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ task(':build:e2eapp:vendor', vendorTask());
/** Builds e2e app ts to js. */
task(':build:e2eapp:ts', tsBuildTask(appDir));

/** No-op (needed by buildAppTask). */
task(':build:e2eapp:scss', sassBuildTask(outDir, appDir));

/** Copies e2e app assets (html, css) to build output. */
task(':build:e2eapp:assets', copyTask(appDir, outDir));

Expand Down