perf(cdk/overlay): add tree-shakeable alternatives for overlay APIs #30904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
adolgachev and
andrewseguin
and removed request for
a team
angular-robot
bot
added
area: performance
andrewseguin
approved these changes
Apr 19, 2025
Currently all the overlay APIs go through the `Overlay` service which means that even if an app only uses the fairly simple global positioning strategy, they'd still bring in all the code for the complex flexible positioning strategy. These changes break up the APIs into constructor functions that can be tree shaken separately. Note that I'll send follow-up PRs to roll this out in Material in order to see the full benefits. From a simple test of a an `ng new` app that only uses `MatTooltip`, this shaved off ~10kb of minified JS.
crisbeto
force-pushed
the
overlay-tree-shake
branch
from
ea6230e to
fb56acd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently all the overlay APIs go through the
Overlayservice which means that even if an app only uses the fairly simple global positioning strategy, they'd still bring in all the code for the complex flexible positioning strategy.These changes break up the APIs into constructor functions that can be tree shaken separately.
Note that I'll send follow-up PRs to roll this out in Material in order to see the full benefits.
From a simple test of a an
ng newapp that only usesMatTooltip, this shaved off ~10kb of minified JS.