fix(cdk-experimental/ui-patterns): listbox pointer event handler #30843
Conversation
wagnermaciel
requested review from
crisbeto and
mmalerba
and removed request for
a team
andrewseguin
added
the
dev-app preview
|
Deployed dev-app for 8287e7f to: https://ng-dev-previews-comp--pr-angular-components-30843-dev-nt74kwid.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
| @@ -270,6 +286,9 @@ export class ListboxPattern<V> { | |||
| if (opts?.selectFromActive) { | |||
| this.selection.selectFromActive(); | |||
| } | |||
| if (opts?.toggleFromAnchor) { | |||
| this.selection.toggleFromPrevSelectedItem(); | |||
There was a problem hiding this comment.
I think this should be toggleFromFocusedItem.
If I click an item to select, then press arrow down several times, then shift click, I'd expect selection to be starting from the focused item, not previously selected item.
There was a problem hiding this comment.
I don't think that's correct. Gmail & React Aria both select from the previous selected
Edit: Also see https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/multiple
There was a problem hiding this comment.
We prob shouldn't use gmail as a reference, though
There was a problem hiding this comment.
Yeah okay, trying it again I think Im wrong. LGTM!
wagnermaciel
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.