fix(cdk-experimental/listbox): ignore spaces during typeahead #30766
Conversation
wagnermaciel
added
the
target: major
wagnermaciel
force-pushed
the
listbox-typeahead
branch
from
088bceb to
7834956
Compare
wagnermaciel
requested review from
crisbeto and
andrewseguin
and removed request for
a team
| @@ -91,6 +91,9 @@ export class ListboxPattern<V> { | |||
| return this.inputs.textDirection() === 'rtl' ? 'ArrowLeft' : 'ArrowRight'; | |||
| }); | |||
|
|
|||
| /** Represents the space key. Does nothing when the user is actively using typeahead. */ | |||
| spaceKey = computed(() => (this.typeahead.query().length ? '' : ' ')); | |||
There was a problem hiding this comment.
how about something like spaceSelectionKey, or something similar, to imply there's more to it than just watching spaceKey?
Below the logic just seems to always trigger on "space key"
There was a problem hiding this comment.
or should this just generally be selectionKey and include the 'Enter' key in this
There was a problem hiding this comment.
We wouldn't be able to include "Enter" unless we change the event manager to also accept Signal. Imo the fact that we're using a signal instead of just the character " " already indicates there's more going on here, but I updated the name to "dynamicSpaceKey" anyway
src/cdk-experimental/ui-patterns/behaviors/list-typeahead/list-typeahead.ts
Outdated
Show resolved
Hide resolved
wagnermaciel
force-pushed
the
listbox-typeahead
branch
from
fe84f96 to
bc750a3
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.