Skip to content

fix(material/sort): set cursor on entire clickable area #30696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

fix(material/sort): set cursor on entire clickable area #30696

merged 1 commit into from
Mar 24, 2025

Conversation

crisbeto
Copy link
Member

Sets the cursor on the entire sort header, rather than the inner container, since the whole element is clickable.

Fixes #30690.

@crisbeto
fix(material/sort): set cursor on entire clickable area
000952c 
Sets the `cursor` on the entire sort header, rather than the inner container, since the whole element is clickable.

Fixes angular#30690.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 24, 2025
@crisbeto crisbeto requested a review from a team as a code owner March 24, 2025 14:27
@crisbeto crisbeto requested review from mmalerba and wagnermaciel and removed request for a team March 24, 2025 14:27
wagnermaciel
wagnermaciel approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 24, 2025
@crisbeto crisbeto merged commit 2d7da0a into angular:main Mar 24, 2025
22 of 25 checks passed
@crisbeto
Copy link
Member Author

The changes were merged into the following branches: main, 19.2.x

crisbeto added a commit that referenced this pull request Mar 24, 2025
@crisbeto
fix(material/sort): set cursor on entire clickable area (#30696)
3ba64d8 
Sets the `cursor` on the entire sort header, rather than the inner container, since the whole element is clickable.

Fixes #30690.

(cherry picked from commit 2d7da0a)
mistrykaran91 pushed a commit to mistrykaran91/components that referenced this pull request Apr 7, 2025
@crisbeto @mistrykaran91
fix(material/sort): set cursor on entire clickable area (angular#30696)
7098e66 
Sets the `cursor` on the entire sort header, rather than the inner container, since the whole element is clickable.

Fixes angular#30690.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: material/sort target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(MatSortHeader): Apply cursor to mat-sort-header (instead of mat-sort-header-container)
3 participants
@crisbeto @mmalerba @wagnermaciel