Skip to content

fix(cdk/menu): not clearing aria-controls on context menu #30680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/cdk/menu/context-menu-trigger.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ describe('CdkContextMenuTrigger', () => {
}

/** Get the context in which the context menu should trigger. */
function getMenuContext() {
function getMenuTrigger() {
return fixture.componentInstance.triggerElement.nativeElement;
}

/** Open up the context menu and run change detection. */
function openContextMenu() {
// right click triggers a context menu event
dispatchMouseEvent(getMenuContext(), 'contextmenu');
dispatchMouseEvent(getMenuTrigger(), 'contextmenu');
fixture.detectChanges();
}

Expand All @@ -57,7 +57,7 @@ describe('CdkContextMenuTrigger', () => {
it('should close out the context menu when clicking in the context', () => {
openContextMenu();

getMenuContext().click();
getMenuTrigger().click();
fixture.detectChanges();

expect(getContextMenu()).not.toBeDefined();
Expand Down Expand Up @@ -143,6 +143,22 @@ describe('CdkContextMenuTrigger', () => {
fixture.detectChanges();
expect(getContextMenu()).toBeDefined();
});

it('should toggle aria-controls depending on if the menu is open', () => {
const trigger = getMenuTrigger();

expect(trigger.hasAttribute('aria-controls')).toBe(false);
expect(getContextMenu()).not.toBeDefined();

openContextMenu();
expect(trigger.getAttribute('aria-controls')).toBeTruthy();
expect(getContextMenu()).toBeDefined();

trigger.click();
fixture.detectChanges();
expect(trigger.hasAttribute('aria-controls')).toBe(false);
expect(getContextMenu()).not.toBeDefined();
});
});

describe('nested context menu triggers', () => {
Expand Down
2 changes: 2 additions & 0 deletions src/cdk/menu/context-menu-trigger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,8 @@ export class CdkContextMenuTrigger extends CdkMenuTriggerBase implements OnDestr
if (item === this.childMenu && this.isOpen()) {
this.closed.next();
this.overlayRef!.detach();
this.childMenu = undefined;
this._changeDetectorRef.markForCheck();
}
});
}
Expand Down
Loading