Skip to content

build: initial attempt to fix docs site deployment #30372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

devversion
Copy link
Member

This fixes a few issues:

  • uses the monorepo checked-in docs sources for deployment of >=v19
  • properly installs dependencies for that repository, avoiding mismatches with the checked-in yarn of the monorepo root.
  • avoids sandbox when launching puppeteer for audits

@devversion devversion requested review from a team as code owners January 22, 2025 16:45
@devversion devversion requested review from crisbeto and amysorto and removed request for a team January 22, 2025 16:45
This fixes a few issues:

- uses the monorepo checked-in docs sources for deployment of >=v19
- properly installs dependencies for that repository, avoiding
  mismatches with the checked-in yarn of the monorepo root.
- avoids sandbox when launching puppeteer for audits
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Jan 22, 2025
@devversion devversion added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jan 22, 2025
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jan 22, 2025
@devversion devversion removed request for a team and amysorto January 22, 2025 17:01
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 22, 2025
@devversion devversion merged commit 7c57f82 into angular:main Jan 22, 2025
28 of 30 checks passed
@devversion
Copy link
Member Author

The changes were merged into the following branches: main, 19.1.x

devversion added a commit that referenced this pull request Jan 22, 2025
This fixes a few issues:

- uses the monorepo checked-in docs sources for deployment of >=v19
- properly installs dependencies for that repository, avoiding
  mismatches with the checked-in yarn of the monorepo root.
- avoids sandbox when launching puppeteer for audits

(cherry picked from commit 7c57f82)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants