Simplify structural style setup #29620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
simplify-core
branch
from
a14e945 to
fbc3bbb
Compare
crisbeto
added
the
merge: preserve commits
crisbeto
force-pushed
the
simplify-core
branch
4 times, most recently
from
7d2d5c5 to
41e493a
Compare
andrewseguin
approved these changes
Aug 22, 2024
| @@ -15,11 +14,7 @@ | |||
| --mat-app-on-surface: initial; | |||
| } | |||
|
|
|||
| @include ripple.ripple(); | |||
crisbeto
force-pushed
the
simplify-core
branch
2 times, most recently
from
461802f to
e28f340
Compare
crisbeto
force-pushed
the
simplify-core
branch
2 times, most recently
from
4487cb2 to
3f85135
Compare
Makes it so the ripple loads the necessary styles itself, instead of requiring the user to do it. BREAKING CHANGE: * The ripples styles are now loaded slightly later than before which can change their specificity. You may have to update any ripple style overrides.
Changes the overlay so it loads its structural styles automatically, instead of requiring the user to do it. BREAKING CHANGE: * The overlay stays are now loaded slightly later than before which can change their specificity. You may have to update any overlay style overrides.
Reworks the text field so that users don't have to manually load its structural styles.
Reworks the style loader to avoid errors if it gets invoked too early.
crisbeto
force-pushed
the
simplify-core
branch
from
3f85135 to
2cc4c65
Compare
angular-robot
bot
added
the
detected: breaking change
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
cdk/overlay,cdk/text-fieldandmaterial/rippleso that they load their structural styles automatically. In the past this has been a source of a lot of bugs.BREAKING CHANGES: