-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/paginator): fix issue with paginator focus #29006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes and issue where focus is lost when on the next, previous, first, or last buttons are disabled. changed to where focus will now jump to next appropriate button instead of focusing to body Fixes b/286098030
refactoring code to make cleaner Fixes b/286098030
refactored code to fix tslint error. added comments to explain code better fixes b/286098030
remove HostListener import fixes b/286098030
fix ts lint issue fixes b/286098030
approved api golden fixes b/286098030
This doesn't seem to capture the case of activating the button via other keypresses or clicks. It's also fragile depending on a 100ms delay to check whether the button becomes disabled and moving focus. Using It'd be nice if there was more intelligence in the paginator to know that a button has focus, but is about to lose focus so that it can directly move it. Right now it seems this change will see the focus move from the button, then to the body temporarily, then to another button. |
How about adding a |
Another alternative is just to set |
Looks like this is resolved by #29379. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes an issue where focus is lost and goes back to the body when on the next, previous, first, or last buttons are disabled. Changed to where focus will now jump to the next appropriate button instead of focusing to body.
Before:
Screen recording 2024-05-07 9.22.24 AM.webm
After:
Screen recording 2024-05-07 9.19.26 AM.webm
Fixes b/286098030