Skip to content

fix(material/slider): update inactive input width on value change #28275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

wagnermaciel
Copy link
Contributor

@wagnermaciel
Copy link
Contributor Author

Stackblitz demo

I've created a demo which makes the hidden input elements visible and outlined so that we can see how changing the value is not currently updating their widths.

https://stackblitz.com/edit/45m3gu?file=src%2Fexample%2Fslider-range-example.html,src%2Fexample%2Fslider-range-example.ts,src%2Fexample%2Fslider-range-example.css,src%2Fstyles.scss

Steps to reproduce

  • Click "Change Values"
  • Note that the inputs have not changed widths to mirror the value changes

Screenshots

Before

Screenshot 2023-12-13 at 1 36 22 PM

After

Screenshot 2023-12-13 at 1 36 58 PM

@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Jan 2, 2024
@wagnermaciel wagnermaciel marked this pull request as ready for review January 2, 2024 17:57
@wagnermaciel wagnermaciel requested review from crisbeto and removed request for devversion and mmalerba January 2, 2024 17:57
@wagnermaciel wagnermaciel added the action: merge The PR is ready for merge by the caretaker label Jan 3, 2024
@wagnermaciel wagnermaciel force-pushed the slider-value-change-bugfix branch from 7960315 to 225ee84 Compare January 3, 2024 19:15
@wagnermaciel wagnermaciel added target: major This PR is targeted for the next major release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release target: major This PR is targeted for the next major release labels Jan 4, 2024
@wagnermaciel wagnermaciel merged commit 6bfbe9b into angular:main Jan 4, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(MatSlider): MatSliderRangeThumb input width is not changed if the input value is changed dynamically
2 participants