fix(cdk/testing): sending incorrect keyCode for comma #27472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
Fixes that the `TestElement.sendKeys` was triggering a keyboard event with the wrong `keyCode` for commas, because a comma has a different `keyCode` than its `charCode`.
crisbeto
force-pushed
the
cdk-testing-comma
branch
from
a40b680 to
a7d08a6
Compare
andrewseguin
approved these changes
Jul 18, 2023
crisbeto
added a commit
that referenced
this pull request
Jul 19, 2023
Fixes that the `TestElement.sendKeys` was triggering a keyboard event with the wrong `keyCode` for commas, because a comma has a different `keyCode` than its `charCode`. (cherry picked from commit 8250a0d)
crisbeto
added a commit
that referenced
this pull request
Jul 20, 2023
crisbeto
added a commit
that referenced
this pull request
Jul 20, 2023
AnthonyFr75
pushed a commit
to AnthonyFr75/components
that referenced
this pull request
Jul 31, 2023
Fixes that the `TestElement.sendKeys` was triggering a keyboard event with the wrong `keyCode` for commas, because a comma has a different `keyCode` than its `charCode`.
AnthonyFr75
pushed a commit
to AnthonyFr75/components
that referenced
this pull request
Jul 31, 2023
…r#27472)" (angular#27485) This reverts commit 8250a0d.
stephenrca
pushed a commit
to stephenrca/components
that referenced
this pull request
Aug 2, 2023
Fixes that the `TestElement.sendKeys` was triggering a keyboard event with the wrong `keyCode` for commas, because a comma has a different `keyCode` than its `charCode`.
stephenrca
pushed a commit
to stephenrca/components
that referenced
this pull request
Aug 2, 2023
…r#27472)" (angular#27485) This reverts commit 8250a0d.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the
TestElement.sendKeyswas triggering a keyboard event with the wrongkeyCodefor commas, because a comma has a differentkeyCodethan itscharCode.