fix(material/checkbox): set checkbox checkmark color with default-con… #27381
+3
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Looks like there are some lint and test failures. Can you look into it @stephenrca? |
|
Hi,
Thanks for the feedback.
I'll look at this this week.
Stephen Clodic
Le sam. 1 juil. 2023 à 00:29, Amy Sorto ***@***.***> a écrit :
… Looks like there are some lint and test failures. Can you look into it
@stephenrca <https://github.com/stephenrca>?
—
Reply to this email directly, view it on GitHub
<#27381 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJH4TLRIGUMZTILRXMFUCLTXN5HKZANCNFSM6AAAAAAZXE7AAE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
mmalerba
added
action: merge
stephenrca
force-pushed
the
stephenrca-fix-checkbox-checkmark-color
branch
3 times, most recently
from
34413e0
to
6bd8b18
Compare
stephenrca
requested review from
devversion,
josephperrott,
andrewseguin,
jelbourn,
crisbeto,
zarend and
wagnermaciel
as code owners
angular-robot
bot
added
detected: feature
* docs: Revised the HTML tags * update * update * update * update
…trast Fixes a bug in the Angular Material `checkbox` component where checkmark does not have the right color if theme is set with CSS variables. Fixes angular#27204
stephenrca
force-pushed
the
stephenrca-fix-checkbox-checkmark-color
branch
from
6bd8b18
to
5024837
Compare
angular-robot
bot
removed
detected: feature
zarend
approved these changes
Aug 2, 2023
|
Hi @stephenrca, @mmalerba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…trast
Fixes a bug in the Angular Material
checkboxcomponent where checkmark does not have the right color if theme is set with CSS variables.Fixes #27204