Skip to content

refactor(material-experimental/mdc-snack-bar): switch to new theming API #25273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

crisbeto
Copy link
Member

Reworks the MDC-based snack bar to use the new CSS-variable-based theming APIs.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jul 14, 2022
@crisbeto crisbeto marked this pull request as ready for review July 14, 2022 08:57
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 14, 2022 08:57
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jul 14, 2022
@crisbeto crisbeto force-pushed the mdc-snack-bar-theming-api branch 4 times, most recently from 36476b3 to c100cae Compare July 15, 2022 10:37
Reworks the MDC-based snack bar to use the new CSS-variable-based theming APIs.
@crisbeto crisbeto force-pushed the mdc-snack-bar-theming-api branch from c100cae to 87413be Compare July 15, 2022 10:58
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jul 18, 2022
@crisbeto crisbeto merged commit 1c7b940 into angular:main Jul 18, 2022
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jul 19, 2022
Fixes some code that is out of sync with the code we have internally. I added the extra `@if` when I was resolving issues with angular#25273.
crisbeto added a commit that referenced this pull request Jul 19, 2022
Fixes some code that is out of sync with the code we have internally. I added the extra `@if` when I was resolving issues with #25273.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants