Skip to content

build: use pin instead of replace range strategy #25252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

devversion
Copy link
Member

We always want to pin to the versions we use, and not rely on
version ranges. This is an attempt to fix that the Bazel workspace
file has not been updated.

https://github.com/angular/dev-infra/runs/7289796990?check_suite_focus=true.

We always want to pin to the versions we use, and not rely on
version ranges. This is an attempt to fix that the Bazel workspace
file has not been updated.

https://github.com/angular/dev-infra/runs/7289796990?check_suite_focus=true.
@devversion devversion requested a review from josephperrott July 11, 2022 21:11
@devversion devversion requested a review from a team as a code owner July 11, 2022 21:11
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jul 11, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jul 11, 2022
@devversion devversion merged commit c5d922b into angular:main Jul 11, 2022
devversion added a commit that referenced this pull request Jul 11, 2022
We always want to pin to the versions we use, and not rely on
version ranges. This is an attempt to fix that the Bazel workspace
file has not been updated.

https://github.com/angular/dev-infra/runs/7289796990?check_suite_focus=true.
(cherry picked from commit c5d922b)
devversion added a commit that referenced this pull request Jul 11, 2022
We always want to pin to the versions we use, and not rely on
version ranges. This is an attempt to fix that the Bazel workspace
file has not been updated.

https://github.com/angular/dev-infra/runs/7289796990?check_suite_focus=true.
(cherry picked from commit c5d922b)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants