build: attempt to de-flake harness integration test

[crisbeto]

Tries to de-flake the harness e2e integration test by swapping out mat-select with mat-selection-list. mat-select has been causing flakes in its own Firefox tests too so it's possible that it may be the reason for the integration test flakes as well.

The component being tested doesn't really matter since the integration test is primarily verifying our npm packages.

[crisbeto]

@devversion I'm not sure what is going on with the integration test error, but it seems like a Bazel issue. My guess is that something was depending transitively on material/select to bring in rxjs, but since the radio button doesn't use rxjs at all, that transitive dependency fails.

[crisbeto]

I ended up switching the test to mat-selection-list which seems to work, but here's a failing run with mat-radio-button for reference: https://app.circleci.com/pipelines/github/angular/components/41061/workflows/d378c467-eefa-48cd-b6e9-f1408a119a6b/jobs/388681.

I also debugged it a bit further and it's probably not a Bazel issue, because the same error happened when I install the dependencies manually and run the test script.

[devversion]

Oh yeah, that's one of the v13 APF ESM effects. e.g. Angular core imports from rxjs/operators, but rxjs does not have package exports and in ESM a directory cannot be directly imported unless there is an export mapping for it. We saw that in v13 but it wasn't a concern because we bundle tests, and the app with the Angular CLI.

I believe long term we need to make sure RxJS has the proper export mappings. The v7 exports always use CommonJS for "node" (which seems incorrect) but maybe updating already helps? (In the integration test)

[crisbeto]

I'd rather not depend on a different rxjs version from the rest of the project so it may be simplest to test using the selection list instead of the radio button.

[devversion]

Ah yes. The PR still was stuck on the failing state for me so I thought you looked for a solution. Selection sounds good to me.

Although it would be nice to verify that users have a way to get this working with selenium-webdriver tests that do not seem to be bundled in the CLI? It's our responsibility because we ship APF ESM packages intended for use in the NodeJS runtime

[crisbeto]

I pushed a change to switch back to the radio test and bump up the rxjs version, but it breaks with the same error.

[devversion]

@crisbeto Ahh, I believe it might be due to:

components/integration/harness-e2e-cli/BUILD.bazel

Line 6 in 818b180

CLI_PROJECT_MAPPINGS,

. We always end up with rxjs from the main package json. You could see if you could omit the mapping with value of "rxjs" there.

Potentially using https://github.com/bazelbuild/bazel-skylib/blob/main/docs/dicts_doc.md#dictsomit. The bad part is that rxjs is the value not a key. The key for rxjs is determined in "tools/integration.bzl".

[crisbeto]

Just gave it a shot, but it didn't work.

[devversion]

thanks for giving it a shot. I'm happy to investigate this in my end if you feel like it.

currently it does not work because the key label is different. see:

components/tools/integration.bzl

Line 6 in b5c935a

def _get_archive_label_of_package(package_name):

Maybe make that function public and use it here? (don't forget to add the @npm prefix like in the mappings dict we create)

[crisbeto]

Okay, there we go. I was looking at the _get_archive_label_of_package function before, but I missed the _archive suffix.

[devversion]

LGTM.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}