Skip to content

fix(multiple): fix disabled label style #25181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

fix(multiple): fix disabled label style #25181

merged 1 commit into from
Jul 12, 2022

Conversation

mmalerba
Copy link
Contributor

MDC does not set the disabled text color on the label for the checkbox,
radio, or switch. This change applies it on the Angular Material side.

Fixes b/224789079

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Jun 28, 2022
@mmalerba mmalerba requested a review from crisbeto as a code owner June 28, 2022 19:06
crisbeto
crisbeto reviewed Jun 28, 2022
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My impression was that we were doing this on purpose since historically the disabled text has had poor color contrast.

crisbeto
crisbeto approved these changes Jun 28, 2022
View reviewed changes
@mmalerba
fix(multiple): fix disabled label style
939d2ba 
MDC does not set the disabled text color on the label for the checkbox,
radio, or switch. This change applies it on the Angular Material side.
@mmalerba mmalerba changed the title fix(material-experimental/multiple): fix disabled label style fix(multiple): fix disabled label style Jun 30, 2022
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jun 30, 2022
@mmalerba mmalerba self-assigned this Jun 30, 2022
@mmalerba mmalerba merged commit 3e9bd1e into angular:main Jul 12, 2022
mmalerba added a commit that referenced this pull request Jul 12, 2022
@mmalerba
fix(multiple): fix disabled label style (#25181)
68edf42 
MDC does not set the disabled text color on the label for the checkbox,
radio, or switch. This change applies it on the Angular Material side.

(cherry picked from commit 3e9bd1e)
mmalerba added a commit that referenced this pull request Jul 12, 2022
@mmalerba
fix(multiple): fix disabled label style (#25181)
63d38e6 
MDC does not set the disabled text color on the label for the checkbox,
radio, or switch. This change applies it on the Angular Material side.

(cherry picked from commit 3e9bd1e)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 18, 2022
Update angularmaterial monorepo to v14.0.5 (#1463)
d81de73 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.0.4/14.0.5) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.0.4/14.0.5) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.0.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1405-metal-hamster-2022-07-14)

[Compare Source](angular/components@14.0.4...14.0.5)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [9cd5a6ad70](angular/components@9cd5a6a) | fix | **a11y:** correctly detect focus from input label ([#&#8203;25232](angular/components#25232)) |
| [938aa2fa13](angular/components@938aa2f) | fix | **clipboard:** page jumping on iOS ([#&#8203;25221](angular/components#25221)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [f5bdefe6fd](angular/components@f5bdefe) | fix | **checkbox:** broken appearance in some grid layouts ([#&#8203;25197](angular/components#25197)) |
| [25ce8e775c](angular/components@25ce8e7) | fix | **select:** add selected indication in high contrast mode ([#&#8203;25237](angular/components#25237)) |
| [76c0e9c1cd](angular/components@76c0e9c) | fix | **tabs:** ink bar not shown in some cases ([#&#8203;25218](angular/components#25218)) |

##### material-experimental

| Commit | Type | Description |
| -- | -- | -- |
| [a9c7f59240](angular/components@a9c7f59) | fix | **mdc-button:** always treat icon-button content as an icon ([#&#8203;25200](angular/components#25200)) |
| [7101a91ef5](angular/components@7101a91) | fix | **mdc-form-field:** ensure clip-path does not truncate label early ([#&#8203;25264](angular/components#25264)) |
| [84a4e9a742](angular/components@84a4e9a) | fix | **mdc-form-field:** fix notch visual artifact ([#&#8203;25201](angular/components#25201)) |
| [ce7f42b912](angular/components@ce7f42b) | fix | **mdc-form-field:** use a CSS var for the floating label scale ([#&#8203;25178](angular/components#25178)) |
| [c0716784b2](angular/components@c071678) | fix | **mdc-paginator:** allow form-field density to go lower than -4 ([#&#8203;25192](angular/components#25192)) |

#####

| Commit | Type | Description |
| -- | -- | -- |
| [89bc64a329](angular/components@89bc64a) | fix | making the parse format available for native date adapter extension ([#&#8203;25226](angular/components#25226)) |

##### multiple

| Commit | Type | Description |
| -- | -- | -- |
| [68edf42798](angular/components@68edf42) | fix | fix disabled label style ([#&#8203;25181](angular/components#25181)) |

#### Special Thanks

Andrew Seguin, Kai Schönberger, Kristiyan Kostadinov, Miles Malerba, Oliver Kierepka and Paul Gschwendtner

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTIuMCIsInVwZGF0ZWRJblZlciI6IjMyLjExNS4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1463
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 19, 2022
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmalerba @crisbeto