build: ensure ng-dev command works on windows #25109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently the `ng-dev` command does not work with Git Bash on windows because of the environment variable being set. We should use `ts-node` directly to avoid this issue, and also avoid the `$PWD` access which might not work depending on the shell. Also on the dev-infra side we would need to remove the ts-node shebang and leave the responsibility to the consumer project.
crisbeto
approved these changes
Jun 18, 2022
devversion
added
the
target: patch
devversion
added a commit
that referenced
this pull request
Jun 18, 2022
Apparently the `ng-dev` command does not work with Git Bash on windows because of the environment variable being set. We should use `ts-node` directly to avoid this issue, and also avoid the `$PWD` access which might not work depending on the shell. Also on the dev-infra side we would need to remove the ts-node shebang and leave the responsibility to the consumer project. (cherry picked from commit e09841c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the
ng-devcommand does not work with Git Bash on windowsbecause of the environment variable being set. We should use
ts-nodedirectly to avoid this issue, and also avoid the
$PWDaccess whichmight not work depending on the shell.
Also on the dev-infra side we would need to remove the ts-node shebang
and leave the responsibility to the consumer project.