refactor(cdk/schematics): import AST utilities #24968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports the AST utilities from `@schematics/angular` instead of vendoring them. Previously they were vendored to avoid TS version mismatches, but now the package comes bundled with its own version of TS so it shouldn't be a problem.
crisbeto
force-pushed
the
ast-utils-import
branch
from
d7b7b05 to
6009218
Compare
crisbeto
requested review from
a team,
devversion and
andrewseguin
as code owners
crisbeto
added
P2
devversion
approved these changes
May 25, 2022
There was a problem hiding this comment.
LGTM.
Related conversation for the future: https://angular-team.slack.com/archives/C46U16D4Z/p1652953481392859
crisbeto
added a commit
that referenced
this pull request
May 25, 2022
Imports the AST utilities from `@schematics/angular` instead of vendoring them. Previously they were vendored to avoid TS version mismatches, but now the package comes bundled with its own version of TS so it shouldn't be a problem. (cherry picked from commit 25dcb36)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports the AST utilities from
@schematics/angularinstead of vendoring them. Previously they were vendored to avoid TS version mismatches, but now the package comes bundled with its own version of TS so it shouldn't be a problem.